Issues when trying to set nodemanager_username and _password

[veriton]

We are provisioning SOA/OSB 12.2 on OL using orawls 2.0.19/puppet4 branch (though looking at the code I think the same will apply to 2.0.20).

I am trying to set the nodemanager_username to "nodemanager" (having to match a default config wiz install in that regard). I have put nodemanager_username (& password) in the domain config, and the domain creation is correctly setting that in the domain (domain_1221.py.epp).

Where it fails is trying to start the AdminServer via NM. I think this is handled by the orawls::control class / wls_adminserver type. If I look at wls_adminserver.rb I can see that the node manager username/pass is not passed in, but instead it does an nmConnect (weblogic_user, weblogic_pass...).

Other than my immediate requirement I think it would be very useful to be able to specify the nodemanager credentials since it is common for them to be different from the domain admin. It's a domain-wide setting (all node managers have the same credentials) so ideally it would just be specified on the domain_instance configuration (as I have it already) or at a config-wide level (though all domains in one environment would need the same NM credentials then). However I don't think the orawls::control module works like that, and instead you have to set it as parameters in the wls_adminserver.rb type and control.pp. Then the two parameters would be added to the control_instance for the domain. There would want to be some defaults in there so that it is backwardly compatible with existing configurations (so if you don't specify NM keeps using the wls user/pass).

What does everyone think? A colleague & I could probably make a reasonable job of this and send you a PR if someone can confirm the approach is correct.

TIA!
Simon

[biemond]

Awesome your change are very welcome.
if we can keep the default behaviour like now but you can override them when you want it.

thanks