Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve onDidRequestRebuild handling #151

Open
SeaDve opened this issue Mar 16, 2022 · 0 comments
Open

Improve onDidRequestRebuild handling #151

SeaDve opened this issue Mar 16, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@SeaDve
Copy link
Collaborator

SeaDve commented Mar 16, 2022 •
edited
Loading

Currently, the work that onDidRequestRebuild handler has done is duplicated by handleActiveManifestChanged. So removing onDidRequestRebuild would not change anything at all.

There should be certain changes threshold for each (e.g. changing build options would only trigger RequestRebuild not ActiveManifestChanged)
@bilelmoussaoui bilelmoussaoui added the enhancement New feature or request label Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bilelmoussaoui @SeaDve