Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over patchbay-dark-crystal code and remove Patchbay and Tabs #1

Open
8 tasks done
m4gpi opened this issue Mar 7, 2019 · 8 comments
Open
8 tasks done

Port over patchbay-dark-crystal code and remove Patchbay and Tabs #1

m4gpi opened this issue Mar 7, 2019 · 8 comments
Labels
enhancement New feature or request

Comments

@m4gpi
Copy link
Member

m4gpi commented Mar 7, 2019

Working towards a more user-friendly and lean / stripped back standalone client, we should move towards stripping out Patchbay and using just Patchcore. Currently patchbay gives us extra plugins which we don't want (see

plugins.gatherings,
).

// NOTE - the following two plugins are needed because the /calendar page expects things from them. That needs extracting, or these plugins need to provide dummy plugs to stop the app exploding!
  plugins.gatherings,
  plugins.scry,

Decoupling from Patchbay means porting our code over from patchbay-dark-crystal as it will no longer be used as a plugin in the standalone.

Removing Hypertabs will mean the router will need rewriting / simplifying.

Overall, this will make our UI significantly more open / flexible / versatile and position us well for future design iterations.

TODOs:

  • Remove Patchbay
  • Remove Hypertabs
  • Ensure required depject modules are still present in the application
  • Setup an ssb config file and a server
  • Configure electron to start the server as a background process
  • Simplify the router to render our views
  • Edit app/html/app to render views based on the router

Nice to Haves

  • Configure a development environment that includes a testnet and runs on a separate port. Implement this as a package.json script for easy future development.
@m4gpi m4gpi added the enhancement New feature or request label Mar 7, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 250.0 DAI (250.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented May 16, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 11 months, 1 week from now.
Please review their action plans below:

1) kgibb8 has been approved to start work.

Rip out Patchbay and replace with Patchcore, setup new routing system and app structure. Refractor Patchbay electron into lib/

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@kgibb8 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

3 similar comments
@gitcoinbot
Copy link

@kgibb8 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@kgibb8 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@kgibb8 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@m4gpi m4gpi mentioned this issue May 29, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 250.0 DAI (250.0 USD @ $1.0/DAI) has been submitted by:

  1. @kgibb8

@ceresstation please take a look at the submitted work:

  • PR by @KGibb8

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 250.0 DAI (250.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @KGibb8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants