Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the 'RadioButton' Component #66

Closed
5 tasks done
uparkalau opened this issue Jun 8, 2024 · 0 comments
Closed
5 tasks done

Refactor the 'RadioButton' Component #66

uparkalau opened this issue Jun 8, 2024 · 0 comments
Assignees
Labels
frontend Frontend task/issue

Comments

@uparkalau
Copy link
Contributor

uparkalau commented Jun 8, 2024

We need to enhance the existing "RadioButton" component to ensure it aligns with our application's design system and is fully reusable. @KenanTopal

To-Do List:

  • Create new branch from the develop branch specifically for this task. The branch name should match the issue title exactly for easy reference.

  • Delete/Modify/Create the "RadioButton" component to accept props for:

    • RadioButton text
    • RadioButton selection handler
    • RadioButton style variant
    • Additional styles or classes as needed
  • Ensure the "RadioButton" component can accommodate various style variants, such as primary, secondary, etc., to match our design language.

  • Confirm that the existing styles in ./RadioButtonStyles.css are correctly implemented. Update the stylesheet as needed to support the new prop-based structure. Utilize constants for colors and styles, referencing the global color theme.

  • Define the PropTypes for the "RadioButton" component, follow example:

    RadioButton.propTypes = {
      label: PropTypes.string.isRequired,
      onChange: PropTypes.func.isRequired,
      variant: PropTypes.oneOf(['default', 'primary', 'secondary']),
      className: PropTypes.string,
    };

RadioButton Component

@uparkalau uparkalau added the frontend Frontend task/issue label Jun 8, 2024
@uparkalau uparkalau changed the title Refactor the "RadioButton" Component Refactor the 'RadioButton' Component Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend task/issue
Projects
None yet
Development

No branches or pull requests

3 participants