-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module does not work in react #22
Comments
Is there a recommended alternative to this library that is maintained? |
There is no alternative solution that is maintained by the bpmn.io team, sorry. 😢 |
@ermarkar You pretty much need to use other software to fix the layout manually... see also process-analytics/bpmn-visualization-js#1837 |
I'm having the same issue with the latest version and was able to fix it with the changes in https://github.com/bpmn-io/bpmn-auto-layout/pull/31/files. @corocoto You've decided to close the pull request, but I don't quite understand why. Were you able to solve the issue in a different way? |
@goto-loop, yes, you are right that the solution resolves this problem.
But as I understood @nikku, we should rewrite all the codebase to a specific format (as example, to the And if we should follow this approach, then my PR wasn't relevant. Because the problem lies in other things, and that fix is only a consequence of it. But I can reopen PR if I misunderstood @nikku. It's not a problem. P.S. @nikku, would you like to join the discussion and share your vision? |
I agree that rewriting all code using a consistent style would be nicer than fixing things here and there. However, with the project not being officially maintained, it seems unlikely that this will happen in the near future. So in my opinion it would make sense to fix these kind of "breaking" issues. Just for context: In order to use the package with React at all, you need to clone it, modify the code, build it and then install from your local copy. It's so much effort for a problem that you, @corocoto, have already solved. @nikku It would be great to hear your opinion on this. |
@goto-loop, I like your view on this situation and agree with it. Reopened the PR. |
auto layout is really useful if you are compiling to BPMN from another data source. |
Should start to work with #33 being merged. |
Describe the Bug
installing latest versions and trying the example in the readme leads to
its caused by:
Steps to Reproduce
See above.
Expected Behavior
Expect the layout to work with the latest versions of
bpmn-moddle
.Environment
The text was updated successfully, but these errors were encountered: