Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional configuration #25

Open
bradleyjkemp opened this issue Jan 26, 2018 · 6 comments
Open

Functional configuration #25

bradleyjkemp opened this issue Jan 26, 2018 · 6 comments

Comments

@bradleyjkemp
Copy link
Owner

There are a number of rendering options that might be useful to be exposed to the user.

Probably best way to do this is similar to go-spew: have a Config struct which has the Map function and then a global default options struct which is used by the package level Map function.

@bradleyjkemp
Copy link
Owner Author

bradleyjkemp commented Jan 27, 2018

  • Max inlining size
  • Whether or not to map private fields
  • Full type names (package+type) vs abbreviated (just type name)
  • Maximum depth?
  • List of structs/types to ignore?

@nadilas
Copy link

nadilas commented Dec 16, 2019

Do you need any help on this? Would like to contribute, you were a lifesaver this week. :)

@bradleyjkemp
Copy link
Owner Author

Hey @nadilas, yeah that'd be great! What level would you be happy to contribute at?
If you want I can set up the basic framework (something along the lines of:
https://github.com/bradleyjkemp/cupaloy/blob/master/cupaloy.go#L13
and
https://github.com/bradleyjkemp/cupaloy/blob/master/config.go) and then you can work on the more interesting bit of actually adding config options.

Or you're welcome to do this boilerplate too if you want 🙂

@nadilas
Copy link

nadilas commented Dec 18, 2019

Hi @bradleyjkemp, If you can lay down the framework, I'd be happy to work on the configs. That way you'll have the base structure in your lib as you wanted to design it ;-)

@bradleyjkemp
Copy link
Owner Author

Just added a basic config framework in 1d8faf1 so I think you're good to go 🙂

@nadilas
Copy link

nadilas commented Dec 21, 2019

#41 is a baseline for this, let's discuss where you want to take it ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants