Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to awesome-go! #2

Open
soypat opened this issue Jun 2, 2022 · 1 comment
Open

Add to awesome-go! #2

soypat opened this issue Jun 2, 2022 · 1 comment

Comments

@soypat
Copy link
Contributor

soypat commented Jun 2, 2022

pctl is missing here https://github.com/avelino/awesome-go#science-and-data-analysis!

I can help add tests for coverage if that's an issue.
@brandondube
Copy link
Owner

Thanks for the offer! At tip/HEAD, the coverage is 81.0%. Release 1.2 which brought all the NewBiquadXXX functions about doubled the sloc for the entire package. There are a few branches in those routines which are not tested out of what is frankly laziness. If you'd like to write some regression tests against the earlevel.com biquad calculator v3, I'd gladly accept the PR.

As to awesome-go, I am neutral about that on the whole. I have no problem including pctl in the index, but I personally do not really want to put the awesome badge on the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandondube @soypat