Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding VCF index argument to SelectVariants #8568

Open
meganshand opened this issue Oct 27, 2023 · 3 comments
Open

Adding VCF index argument to SelectVariants #8568

meganshand opened this issue Oct 27, 2023 · 3 comments

Comments

@meganshand
Copy link
Contributor

Feature request

Tool(s) or class(es) involved

SelectVariants

Description

In order to run SelectVariants with VCF inputs that are in separate locations from their index files or to stream SelectVariants using https from Azure blob storage, we need a way to provide the index file in a separate argument from the -V input. @jamesemery started thinking this through (copying this from slack):

In featureDataSource.getTribbleFeatureReader() we currently initialize the datasources in getFeatureReader() which gets called by VariantWalker.initializeDrivingVariants() . You could stick an override into that where you thread down the path for the index source through that path and optionally (only if the index is explicitly supplied by the user) push it down into the getTribbleFeatureReader() calls at the bottom of the stack there.

@droazen any thoughts on this? @VJalili Would adding this feature to SelectVariants be useful for your pipelines at all?

@droazen
Copy link
Collaborator

droazen commented Oct 30, 2023

@meganshand We would like to add in a global mechanism for passing in explicit VCF indices, which we have long had for BAM/CRAM indices. @ldgauthier has requested this many times as well. We have a mechanism implemented in HTSJDK that allows you to pass in a JSON file (which we call a Bundle) containing URLs to both the main file and companion index, wherever you can currently pass in a raw file URL. Would this meet your needs?

@meganshand
Copy link
Contributor Author

@droazen Yes, that sounds very convenient to use.

@mchenaux
Copy link

Hi, I would like to be able to pass fasta index files in separate locations for HaplotypeCaller as well. Is there currently an option for that? I see that --read-index is for passing .bai explicitly but do not see any such flag for .fai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants