Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not close the file in the end of brut.androlib.src.SmaliBuilder.buildFile(..)? #6

Open
mcai opened this issue Nov 19, 2011 · 0 comments

Comments

@mcai
Copy link

mcai commented Nov 19, 2011

Hi Brutall,

Thanks for your great job.

I've encountered the java.io.FileNotFoundException (Too many open files) when I use apktool to build lots of smali files for a large apk file in a resource restricted environment.

The real problem is:

Why not close the file (input stream) in the end of brut.androlib.src.SmaliBuilder.buildFile(..)? If there are lots of smali files to build, not closing the opened files will cause java.io.FileNotFoundException (Too many open files) in the middle of SmaliBuilder.build(..).

Looking forward to your reply.

Thanks.

Yours sincerely,

Min Cai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant