Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ebooks integration #230

Closed
btzr-io opened this issue Nov 27, 2019 · 12 comments
Closed

Ebooks integration #230

btzr-io opened this issue Nov 27, 2019 · 12 comments

Comments

@btzr-io
Copy link
Owner

btzr-io commented Nov 27, 2019

What other formats should this support besides compressed archives ?

I think epub is a good option, pdf is also commonly used but it wont be a optimized for text content, just images.

Possible solution

https://github.com/mozilla/pdf.js
https://github.com/futurepress/epub.js/

@DaniAcu
Copy link
Contributor

DaniAcu commented Jan 3, 2020

I’m super excited to take it. Assign me if you want

@btzr-io
Copy link
Owner Author

btzr-io commented Jan 6, 2020

@DaniAcu I'm not sure whats the right approach to handle this, or if is relevant to have internally, maybe create a plugin for this ?
#214

@DaniAcu
Copy link
Contributor

DaniAcu commented Jan 6, 2020

Awesome. Let me spike that on this week and share some ideas about how start with that

@btzr-io btzr-io pinned this issue Jan 11, 2020
@DaniAcu
Copy link
Contributor

DaniAcu commented Jan 30, 2020

I tried many ideas and read a lot. So now I think that we could use a Factory. Check this sample and tell me if you are agree with that and I could start implementing that. https://sourcemaking.com/design_patterns/factory_method/java/1

@btzr-io
Copy link
Owner Author

btzr-io commented Feb 2, 2020

@DaniAcu Looks interesting, sure feel free to open a PR, let me know if you have more questions or need any help ✌️

@DaniAcu
Copy link
Contributor

DaniAcu commented Feb 2, 2020

Thanks maybe if you have some documentation about how works the renderer or some overview could be helpful.

@btzr-io
Copy link
Owner Author

btzr-io commented Feb 4, 2020

The render is just a react component for openseadragon
https://github.com/btzr-io/Villain/blob/master/packages/villain-react/src/components/render.js
There are no docs of villain yet, but this should help:
https://openseadragon.github.io/docs/

Ebooks shouldn't use this anyway.

@btzr-io
Copy link
Owner Author

btzr-io commented Apr 26, 2020

@DaniAcu Hooks should help with this #446

@btzr-io btzr-io unpinned this issue May 10, 2020
@DaniAcu
Copy link
Contributor

DaniAcu commented Aug 9, 2020

I was looking into all the code.
The first one is that all files that we are supporting, is support like image containers. Because on uncompress.js we are creating pages according to the image that we have on the Blob.
If we just support images, because that it's rendered just comics. It's fine and epub is already supported. But if we want to extend our reader to be used on books or other things.
What it's the idea, we won't go to support another style of file or we are just supporting comics.

@btzr-io
Copy link
Owner Author

btzr-io commented Aug 9, 2020

It's fine and epub is already supported

Epub is not supported yet, thats why I open this issue to track development of more ebook formats like epub pdf etc...

@btzr-io
Copy link
Owner Author

btzr-io commented Aug 9, 2020

The priority is to support comic-archive files, but if we could extend the support to other files / formats that will be great. Maybe as a plugin or extension if is not a viable option to add it in the main repo.

@btzr-io
Copy link
Owner Author

btzr-io commented Sep 4, 2020

This definitely should be a plugin or extension, not priority, I'll close this for now.

@btzr-io btzr-io closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants