Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't preview Changelog before it is pushed #67

Open
dhinus opened this issue Feb 1, 2017 · 2 comments
Open

can't preview Changelog before it is pushed #67

dhinus opened this issue Feb 1, 2017 · 2 comments
Assignees

Comments

@dhinus
Copy link

dhinus commented Feb 1, 2017

smooth-release should pause between UPDATE CHANGELOG and COMMIT AND PUSH CHANGES, so you can inspect the ChangeLog that was generated locally, before it is pushed to GitHub.

@FrancescoCioria
Copy link
Contributor

After the first time the changelog usually changes just a little and only with additions.
If you like it, we could consider showing a nice diff of the changelog (we could simply run git diff).

This should be enough in most cases and, as it's blocking anyway (you have of course to confirm the diff) you may inspect the changelog fully through a new terminal window.

I'm still not sure if this should be the default behavior though... do everyone really care about it? I personally never did :)

@dhinus
Copy link
Author

dhinus commented Feb 6, 2017

A diff would be good. I'd like it to be the default behaviour for a few reasons:

  • if there is a bug in smooth-release you can stop before a wrong Changelog is committed (like in Changelog does not consider the new tag added by npm-version task #68)
  • you might have forgotten a "breaking" label, or notice something should be listed under "fixes" instead of "new features". If you see the diff, you can exit, modify some labels, and try again
  • I think having all prompts enabled is safer for new users, and disabling a prompt should be an "expert" feature you explicitly enabled in the config file or with a command-line flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants