Ambiguous npm-version task question when manually overriding

[ecamellini]

description

When passing version/increase level as argument, to override the npm-version task behaviour, smooth-release still asks "Do you want to run the "npm-version" task and increase the version of your library? (y/n)".

This is can be confusing, since the user already passed the desired version as a parameter and does not want to determine it automatically. However, answering n results in skipping some other important steps (package.json update, git tag, etc.).

A more intuitive behaviour could be:

1. Run the "Compute release" task directly, without asking any confirmation, to show the release number that smooth-release automatically determines
2. If the user passed a parameter to override this behaviour, ask confirmation to do it. For example: "Smooth-release computed 0.5.3 as the version to release, are you sure you want to override it with 0.6.0? (y/n)". If no parameter were passed, just ask for confirmation.
3. Continue with the next steps as they are (package.json update, git tag, etc.)

[FrancescoCioria]

👍 I like this, I think like this it will be more intuitive for the user.

If the user passed a parameter to override this behaviour, ask confirmation to do it. For example: "Smooth-release computed 0.5.3 as the version to release, are you sure you want to override it with 0.6.0? (y/n)". If no parameter were passed, just ask for confirmation.

What if the user passes the same version? (I would skip this step and act as if they responded with y)

PS: this doesn't look like a defect but more like a feature (and a breaking one) so I fixed the labels

[ecamellini]

In case of same version I would skip the confirmation too, and maybe just show a message that notifies the user about it (e.g., you selected version x.y.x, the same computed by smooth-release, or something similar) 👍