Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable notification on create or update components #2605

Closed
igramnet opened this issue Jun 27, 2017 · 7 comments
Closed

Disable notification on create or update components #2605

igramnet opened this issue Jun 27, 2017 · 7 comments
Milestone

Comments

@igramnet
Copy link

Hello.
[https://github.com//issues/2592](Close issue)

I do not agree with the closure of the ticket. I just want to disable notifications when adding and updating components. Now I had to find the file \ resources \ app \ Foundation \ Providers \ EventServiceProvider.php and delete the line

'CachetHQ\Cachet\Bus\Events\Component\ComponentWasUpdatedEvent' => [ 'CachetHQ\Cachet\Bus\Handlers\Events\Component\SendComponentUpdateEmailNotificationHandler', ],

This solution is not correct.

@jbrooksuk
Copy link
Member

No problem! I'd like to see a PR which prevents notifications. Needs a checkbox of some kind. Would you like to contribute it?

@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Jun 28, 2017
@igramnet
Copy link
Author

Yes, I need a checkbox. Those. Globally configure multiple options

  1. Send notification when updating component (subscribers)
  2. Sending notifications when adding a component (subscribers)

Here's what I found.
The subscriber unsubscribed from the component. Then the administrator started the mailing (incident), specifying this component. The newsletter still came to this subscriber. It's somehow illogical, is not it?

@jbrooksuk
Copy link
Member

If the subscriber unsubscribed from the component but were still mailed, were the subscribed globally?

@d-core
Copy link

d-core commented Oct 4, 2017

Hi,

I would like to join the discussion. If I’m correct, this requests fits our needs. We also want to disable the mail notification if we change the component status on the dashboard. The notification, if we create incident or scheduled maintenance, should remain. So un-subscription is not the solution.

Regards

@igramnet
Copy link
Author

igramnet commented Oct 6, 2017

Yes, I meant it.

@jbrooksuk
Copy link
Member

@d-core 2.4 will no longer notify when making simple changes from the dashboard homepage.

@jbrooksuk
Copy link
Member

Grouping this issue into #2508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants