Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to not notify subscribers about maintenance #3562

Closed
MinThaMie opened this issue Apr 25, 2019 · 3 comments · Fixed by #3567
Closed

Option to not notify subscribers about maintenance #3562

MinThaMie opened this issue Apr 25, 2019 · 3 comments · Fixed by #3567
Labels
Dashboard Good First Issue If you're looking for a good issue to PR, start here Help Wanted Issues that need more help Scheduled Maintenance

Comments

@MinThaMie
Copy link
Contributor

When creating an incident you have the option to notify the subscribers. It would be cool if the same could be added for the maintenance

Dashboard -> Indicents -> Report an incident

Screenshot 2019-04-25 at 10 19 12

@MinThaMie
Copy link
Contributor Author

Might also be useful to add to the edit of a incident, because this is might still be something you want to do at a later stage

@jbrooksuk jbrooksuk added Help Wanted Issues that need more help Good First Issue If you're looking for a good issue to PR, start here Dashboard labels Jun 23, 2019
@jbrooksuk
Copy link
Member

Hi @MinThaMie. This is a good idea and I'd love for someone to take this on.

A rough guideline for this:

Note that you can use incidents as a base to go on for this.

  1. Add a column of notify to the schedules table
  2. Add the notify column to the schedules dashboard page
  3. Update the bus command to be aware of the new value
  4. Update the event handler (SendScheduleEmailNotificationHandler) to send the notification based on whether to notify or not

@jbrooksuk
Copy link
Member

Oh, sorry @MinThaMie, you've already done it! 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Good First Issue If you're looking for a good issue to PR, start here Help Wanted Issues that need more help Scheduled Maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants