Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync the template content in nirvana init with nirvana-template-project repo #304

Closed
iawia002 opened this issue Apr 9, 2020 · 3 comments · Fixed by #323
Closed

Sync the template content in nirvana init with nirvana-template-project repo #304

iawia002 opened this issue Apr 9, 2020 · 3 comments · Fixed by #323
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@iawia002
Copy link

iawia002 commented Apr 9, 2020

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

Since we have the nirvana-template-project repo, maybe we should sync the template content in nirvana init command with nirvana-template-project repo, and then deprecate nirvana-template-project repo, all nirvana projects can be easily generated by nirvana init xxx.

And since almost all projects have migrated to go mod, maybe we can also drop support for generating project with dep as a package manager, just go mod.

/cc @supereagle @hezhizhen

@caicloud-bot caicloud-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 9, 2020
@hezhizhen
Copy link
Contributor

SGTM

@iawia002
Copy link
Author

/assign

@supereagle
Copy link
Member

then deprecate nirvana-template-project repo, all nirvana projects can be easily generated by nirvana init xxx

Maybe not all of nirvana-template-project can be covered by nirvana init xx, like Dockerfile and Makefile.

And since almost all projects have migrated to go mod, maybe we can also drop support for generating project with dep as a package manager, just go mod.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants