Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed phrase backup #140

Closed
3 tasks done
KKA11010 opened this issue Aug 19, 2023 · 5 comments · Fixed by #300
Closed
3 tasks done

Seed phrase backup #140

KKA11010 opened this issue Aug 19, 2023 · 5 comments · Fixed by #300
Assignees
Labels
completed 🌟 Changes are already available and have to be merged help wanted Extra attention is needed new feature New feature request priority: high high priority task UX User experience related

Comments

@KKA11010
Copy link
Collaborator

KKA11010 commented Aug 19, 2023

  • Generate seed phrase
  • Show seed phrase
  • Restore wallet

Implemented by

@KKA11010 KKA11010 added enhancement New feature or request help wanted Extra attention is needed UX User experience related labels Aug 19, 2023
@KKA11010 KKA11010 self-assigned this Aug 19, 2023
@KKA11010 KKA11010 added new feature New feature request and removed enhancement New feature or request labels Aug 22, 2023
@KKA11010 KKA11010 added the priority: high high priority task label Nov 17, 2023
@BrunswickBTC
Copy link

This looks really simple to me. What is the holdup? Is the problem the lack of definition on the UI?

@KKA11010
Copy link
Collaborator Author

KKA11010 commented Nov 24, 2023

This looks really simple to me. What is the holdup? Is the problem the lack of definition on the UI?

This is a very big and important task and I dont find it simple. There are a lot of factors that collectively require time and effort for a reliable implementation. (logic, ui/ux, testing, review) You can go for it and provide a PR 👀

I am currently busy with updating the layout to provide a responsive UI on all smartphone sizes with different dpi and some bug fixing.

@BrunswickBTC
Copy link

I can try to help with the back end, but I'm lost about how you envision the ui portion should be structured

@KKA11010
Copy link
Collaborator Author

I can try to help with the back end, but I'm lost about how you envision the ui portion should be structured

There is no UI design for this yet.

Sounds amazing, you can of course dive into it and try to implement the basics using cashu-ts rc7.

Few things to look out for (notes from the cashu-ts maintainers):

  • You need to keep track of a counter per keyset for each proof
  • the counter should only increment once valid proofs are received.
  • you can count the proofs after calling send() receive() ... etc. , and increment the counter per keyset accordingly.
  • for activating deterministic secrets in addition to provide the count on each function call, you need to initialize the CashuWallet with a mnemonic. there is a function for generating a new mnemonic in the lib.

more resources: deterministic secrets and restore from seed phrase

@BrunswickBTC
Copy link

I'll set up the dev environment and see what I can do.

@KKA11010 KKA11010 added the completed 🌟 Changes are already available and have to be merged label Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed 🌟 Changes are already available and have to be merged help wanted Extra attention is needed new feature New feature request priority: high high priority task UX User experience related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants