-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discussion] Extension's Structure Proposal #4
Comments
I have been meaning to start this discussion for the last month but it was not until last week that I met wit the members of the Cladinin group. Recently, the Cladinin lab came with a proposal for doing imaging registration to standard atlases called Bifrost. While the details of how to do registration are complex I think that we can move the NWB format further by having at least the ability to express the most basic of spatial coordinates transformations: the affine transform. In fmri neuroimaging the transformation is used to express how the data in voxel space (i.e. the data as it is) could be transformed into some real world coordinates. A good summary can be found in the following tutorial but the idea is simple, every image / video has a matrix of the following kind: That is used to express the rotations and translations that would be necessary to express the data as it is (the voxel or pixel space) into lab coordinates. Right now, I think that the current elements of the ImagingPlane map to the following elements of the Affine matrix formulation for expressing real world coordinates:
As you see we are missing the ability to express rotations that usually affect the non-diagonal terms of the matrix (and also the diagonal). That is, the having the concept of the affine matrix will generalize two our fields and expand the expressive power of proposed The limitation of this is that it only allows us to express affine transformations. Non-affine transformations are a different type of beast. One representation of non-affine transformations are displacement fields where basically every voxel has a vector assigned to them indicating how they should be changed. In nifti they are represented with the following structure:
We could include a general |
Another concept that maybe needs refinment is the use and scope of the reference frame field. Currently we have reference_frame that expresses as a description of what the origin is (e.g. Bregma). For example, here is the origin as Bregma in the Paxinos atlas. Which is what I think inspired the field at the time. However, in neuro imaging it seems more common to agree that the axis are given anatomically (right-left, posterior-anterior, inferior-superior) and then there are different conventions for the signs of the given axes. Check this image: That is, if we are gona use the reference_frame field or something else as a description of the what do the axes mean maybe we should update the string to contain a set of working examples as the current one is not very descriptive in my opinion. |
With regards to the light source, what are the intended values to record under power and intensity? Is it the power/intensity of the light source itself, or the power/intensity measured under the objective, which in most cases are the most meaningful to record? I assume a description of this would be added in the doc, but maybe it could be made more explicit by for example consider names like for example |
For the topic of coordinates a good discussion can be found here: |
This issue is to discuss the extension structure.
With the first proposal I try to keep in consideration all the ideas in #1, the metadata in other standards as suggested in #3 and some issues reported in nwb-schema:
(1)[https://github.com/NeurodataWithoutBorders/nwb-schema/issues/538]
(2)[https://github.com/NeurodataWithoutBorders/nwb-schema/issues/517]
(3)[https://github.com/NeurodataWithoutBorders/nwb-schema/issues/431]
(4)[https://github.com/NeurodataWithoutBorders/nwb-schema/issues/406]
(5)[https://github.com/NeurodataWithoutBorders/nwb-schema/issues/343]
(6)[https://github.com/NeurodataWithoutBorders/pynwb/issues/1736]
NB:
Ophys Acquisition
Optogenetics
it also take into account the extensions for patterned photostimulation: https://github.com/catalystneuro/ndx-holographic-stimulation, https://github.com/histedlab/ndx-photostim
![ndx-ogen](https://private-user-images.githubusercontent.com/55453048/284568922-c9f13ca0-f085-4e12-abdf-deba01bb968d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5NjcyMjgsIm5iZiI6MTcyNTk2NjkyOCwicGF0aCI6Ii81NTQ1MzA0OC8yODQ1Njg5MjItYzlmMTNjYTAtZjA4NS00ZTEyLWFiZGYtZGViYTAxYmI5NjhkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDExMTUyOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI3MWQ0NGJlNjgzM2U3YjI4YzNlMzNlZmE0MDEwMzg5OWE1NDcyYmY2NjEwZGY3ODJhNjc5NDRlZDVmNGEzMzAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.BMoh1_hfd17zN1n5USuhW6bUm9VZsz2LidwWcut2UwU)
The text was updated successfully, but these errors were encountered: