Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic style support for Easy Digital Downloads #92

Open
cdils opened this issue Apr 11, 2017 · 7 comments
Open

Add basic style support for Easy Digital Downloads #92

cdils opened this issue Apr 11, 2017 · 7 comments

Comments

@cdils
Copy link
Owner

cdils commented Apr 11, 2017

At last look, no Genesis child themes explicitly offered support for EDD. I'd like to consider adding styles (and possibly templates) for product archives and single product views.

I've thought in the past about adding WooCommerce styles as well. Perhaps both EDD and Woo styles would make more sense as complimentary plugins versus baked into Utility Pro.

Thoughts?

@gspice
Copy link
Collaborator

gspice commented Apr 12, 2017

I was just thinking of this as I was looking at the EDD site the other day! It could be a gold mine for theme sales and possibly get added to the EDD theme page?

@jdelia
Copy link
Collaborator

jdelia commented Apr 13, 2017

This is an excellent idea.

@cdils
Copy link
Owner Author

cdils commented Jul 20, 2017

I'm thinking to include a .scss stylesheet for EDD in the /scss/partials/ directory. When compiled for distribution, that file should be excluded from style.css and instead compiled off the root directory to /edd_templates/edd.css per these instructions of how to include custom styles for EDD.

@GaryJones I know this will require some modifications to the Gulp file. Do you see any problems with the approach I'm suggesting?

@GaryJones
Copy link
Collaborator

Go for it.

@cdils
Copy link
Owner Author

cdils commented Jul 26, 2017

@GaryJones It is unclear to me how to configure (extend?) gulp-wp-toolkit to compile a partial into a different file. I pinged @craigsimps a day ago in Slack, but haven't had a response.

@GaryJones
Copy link
Collaborator

We'll need to tweak how the internals of gulp-wp-toolkit works: craigsimps/gulp-wp-toolkit#41

@cdils
Copy link
Owner Author

cdils commented Jul 28, 2017

Thanks @GaryJones. While I like gulp-wp-toolkit generally, I'm getting nervous about relying on a 3rd party library that doesn't currently offer full support for what UP needs. The only hold up getting this theme to market should be me. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants