Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assert statements with more informative errors. #6

Open
Ianlmgoddard opened this issue Jul 26, 2024 · 0 comments
Open

Replace assert statements with more informative errors. #6

Ianlmgoddard opened this issue Jul 26, 2024 · 0 comments
Labels
✨ enhancement New feature or request

Comments

@Ianlmgoddard
Copy link
Contributor

To validate the user inputs to the sbr calculations we call assert to check if the user has provided inputs of the correct type -

.

I don't think this is recommended and we should be using either [TypeError](https://docs.python.org/3/library/exceptions.html#TypeError. ) or ValueError. This is more informative for users of the package as it clearly tells the user that they have a problem with their inputs.

@Ianlmgoddard Ianlmgoddard added the ✨ enhancement New feature or request label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant