Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address.NewAddressFromAccountID(): Missing error return on malformed address #321

Closed
tpj opened this issue Jan 9, 2023 · 1 comment
Closed

Address.NewAddressFromAccountID(): Missing error return on malformed address #321

tpj opened this issue Jan 9, 2023 · 1 comment

Comments

@tpj
Copy link

tpj commented Jan 9, 2023

In v.4.0.10 it looks like nil is returned instead of err:
https://github.com/centrifuge/go-substrate-rpc-client/blob/master/types/address.go#L40
@cdamian
Copy link
Contributor

cdamian commented Dec 5, 2023

Will be fixed in - #366

@cdamian cdamian closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tpj @cdamian