Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls and subscriptions should accept a context #38

Closed
philipstanislaus opened this issue Nov 28, 2019 · 2 comments
Closed

Calls and subscriptions should accept a context #38

philipstanislaus opened this issue Nov 28, 2019 · 2 comments

Comments

@philipstanislaus
Copy link
Contributor

Calls should accept a context so they can be cancelled and can receive a timeout.

Subscriptions need a bit more investigation – a context could be used to cancel or timeout the subscription, but the current subscription logic already exposes an Unsubscribe method that can be used for both purposes.

@johnuopini
Copy link

I definitely need this, i create a client every 2/3 minutes to get data from chain, if the client gets stuck i have no way to cancel that call and retry, i haven't found any fix so far, having an additional constructor that accepts a context or add a context to the call would be great

@cdamian
Copy link
Contributor

cdamian commented Dec 5, 2023

The Client interface will be updated here - #366 to include the CallContext method. We will not update any RPC clients as of now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants