cephfs: Support mount option on nodeplugin #3233
Merged
+51
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takmatsu
force-pushed
the
add-mount-option
branch
2 times, most recently
from
9cc6e3a
to
4eaa9b2
Compare
Rakshith-R
added
enhancement
takmatsu
changed the title
|
This might be useful, but it would be good to also have this for RBD so that the two have very similar features. Can you give your practical example in this PR, explain what options you would like to configure this way? |
nixpanic
reviewed
Jul 8, 2022
takmatsu
force-pushed
the
add-mount-option
branch
from
876a57e
to
97026a2
Compare
|
Thanks for the update! Could you squash the 2nd commit in the 1st, please? Looks good to me otherwise 👍 |
takmatsu
force-pushed
the
add-mount-option
branch
from
97026a2
to
a06b9f5
Compare
Rakshith-R
approved these changes
Jul 18, 2022
yati1998
approved these changes
Jul 18, 2022
nixpanic
approved these changes
Jul 18, 2022
|
@Mergifyio rebase |
add mount options on nodeplugin side Signed-off-by: takeaki-matsumoto <[email protected]>
✅ Branch has been successfully rebased |
ceph-csi-bot
force-pushed
the
add-mount-option
branch
from
a06b9f5
to
6454987
Compare
|
/retest ci/centos/upgrade-tests-rbd |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
/retest ci/centos/k8s-e2e-external-storage/1.22 |
|
/retest ci/centos/k8s-e2e-external-storage/1.21 |
|
/retest ci/centos/k8s-e2e-external-storage/1.23 |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
/retest ci/centos/mini-e2e/k8s-1.23 |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This PR adds supporting mount option on nodeplugin.
I know currently StorageClass or Volume can have same configuration.
But sometimes several options of them are almost same. so I feel adding same options on all storage class is a bit useless.
and also StorageClass can't be changed basically though mounting should be the responsibility of nodeplugin side.
So I believe this PR should be convenient also for other users.
my typical example option
recover_session=cleanIs there anything that requires special attention
no breaking changes
Related issues
None
Future concerns
None
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any testprogress or results