util: make inode metrics optional in FilesystemNodeGetVolumeStats() #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
added
component/cephfs
nixpanic
force-pushed
the
cephfs/optional-inodes
branch
from
55acd5d
to
d28a1d3
Compare
|
/test ci/centos/k8s-e2e-external-storage/1.22 |
1 similar comment
|
/test ci/centos/k8s-e2e-external-storage/1.22 |
Madhu-1
approved these changes
Oct 5, 2022
Rakshith-R
approved these changes
Oct 6, 2022
|
@Mergifyio rebase |
CephFS does not have a concept of "free inodes", inodes get allocated on-demand in the filesystem. This confuses alerting managers that expect a (high) number of free inodes, and warnings get produced if the number of free inodes is not high enough. This causes alerts to always get reported for CephFS. To prevent the false-positive alerts from happening, the NodeGetVolumeStats procedure for CephFS (and CephNFS) will not contain inodes in the reply anymore. See-also: https://bugzilla.redhat.com/2128263 Signed-off-by: Niels de Vos <[email protected]>
✅ Branch has been successfully rebased |
Madhu-1
force-pushed
the
cephfs/optional-inodes
branch
from
d28a1d3
to
60bcc6a
Compare
|
/retest ci/centos/mini-e2e/k8s-1.22 |
|
/retest ci/centos/mini-e2e/k8s-1.23 |
|
/retest ci/centos/mini-e2e/k8s-1.24 |
|
/retest /retest ci/centos/mini-e2e/k8s-1.22 |
|
/retest /retest ci/centos/mini-e2e/k8s-1.23 |
|
/retest /retest ci/centos/mini-e2e/k8s-1.24 |
|
/retest ci/centos/k8s-e2e-external-storage/1.22 |
|
/retest ci/centos/k8s-e2e-external-storage/1.23 |
|
/retest ci/centos/k8s-e2e-external-storage/1.24 |
|
/retest ci/centos/upgrade-tests-rbd |
|
/retest ci/centos/upgrade-tests-cephfs |
|
/retest ci/centos/mini-e2e-helm/k8s-1.22 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.23 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.24 |
4 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CephFS does not have a concept of "free inodes", inodes get allocated on-demand in the filesystem.
This confuses alerting managers that expect a (high) number of free inodes, and warnings get produced if the number of free inodes is not high enough. This causes alerts to always get reported for CephFS.
To prevent the false-positive alerts from happening, the NodeGetVolumeStats procedure for CephFS (and CephNFS) will not contain inodes in the reply anymore.
See-also: https://bugzilla.redhat.com/2128263
Manually Tested
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any testprogress or results