Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not add ok-to-test if CentOS jobs were successful #3688

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

nixpanic
Copy link
Member

Mergify does not add the ok-to-test label immediately anymore. But once the CentOS CI jobs have finished, the label still gets added. With the additional check, this should not be the case anymore.


Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)
  • /retest all: run this in case the CentOS CI failed to start/report any test
    progress or results

@nixpanic nixpanic added component/testing Additional test cases or CI work ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Feb 22, 2023
Mergify does not add the `ok-to-test` label immediately anymore. But
once the CentOS CI jobs have finished, the label still gets added. With
the additional check, this should not be the case anymore.

Signed-off-by: Niels de Vos <[email protected]>
@nixpanic nixpanic marked this pull request as ready for review February 22, 2023 12:54
@nixpanic nixpanic requested review from Madhu-1 and a team February 22, 2023 12:54
@Madhu-1 Madhu-1 requested a review from a team February 22, 2023 14:16
@nixpanic nixpanic merged commit 991c21f into ceph:devel Feb 22, 2023
@nixpanic nixpanic deleted the mergify/ok-to-test branch February 22, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants