Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install Helm with script located on GitHub #3843

Merged
merged 1 commit into from
May 22, 2023

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented May 22, 2023

Installing Helm fails often in the CI. The Helm documentation does not point to https://git.io/get_helm.sh anymore, but to a location on GitHub. To make it easier to update the location in the future, it has now been added to build.env, just like the HELM_VERSION.

See-also: https://helm.sh/docs/intro/install/

The failures in CI jobs would look like this:
image

Installing golangci-lint succeeds, the next curl command fails.


Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)
  • /retest all: run this in case the CentOS CI failed to start/report any test
    progress or results

@mergify mergify bot added the component/testing Additional test cases or CI work label May 22, 2023
@nixpanic nixpanic requested a review from a team May 22, 2023 07:34
@@ -34,6 +34,9 @@ SNAPSHOT_VERSION=v6.1.0
#TEST_COVERAGE=html
#GO_COVER_DIR=_output/

# URL for the script to install Helm
HELM_SCRIPT=https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using script from main branch is risky, possible to use latest released version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what is recommended in the documentation. I expect that the previous URL pointed to the same version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note that it is only used for installing. The version pointed to by HELM_VERSION will be installed and used.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a bug in script we will.b3 easily affected as its from main branch, let's handle it in different PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that is needed. Hopefully their main branch is at least as stable as our devel branch.

@nixpanic nixpanic requested a review from Madhu-1 May 22, 2023 07:41
@Madhu-1 Madhu-1 requested a review from a team May 22, 2023 07:42
@nixpanic nixpanic added ci/skip/multi-arch-build skip building on multiple architectures ok-to-test Label to trigger E2E tests labels May 22, 2023
@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.24

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.25

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.26

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.27

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.26

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.27

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.26

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.27

@github-actions
Copy link

/test ci/centos/upgrade-tests-cephfs

@github-actions
Copy link

/test ci/centos/upgrade-tests-rbd

@github-actions github-actions bot removed the ok-to-test Label to trigger E2E tests label May 22, 2023
@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e-helm/k8s-1.26

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e-helm/k8s-1.26

Failed to install packages from the CentOS build system:

Errors during downloading metadata for repository 'ganesha':

  - Curl error (7): Couldn't connect to server for https://buildlogs.centos.org/centos/8/storage/x86_64/nfsganesha-4/repodata/repomd.xml [Failed to connect to buildlogs.centos.org port 443: Connection refused]

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e/k8s-1.26

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e/k8s-1.26

  May 22 08:41:56.018: backend images not matching kubernetes resource count,image count 1 kubernetes resource count 0

Installing Helm fails often in the CI. The Helm documentation does not
point to `https://git.io/get_helm.sh` anymore, but to a location on
GitHub. To make it easier to update the location in the future, it has
now been added to `build.env`, just like the `HELM_VERSION`.

See-also: https://helm.sh/docs/intro/install/
Signed-off-by: Niels de Vos <[email protected]>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label May 22, 2023
@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.24

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.25

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.26

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.27

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.26

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.27

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.26

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.27

@github-actions
Copy link

/test ci/centos/upgrade-tests-cephfs

@github-actions
Copy link

/test ci/centos/upgrade-tests-rbd

@github-actions github-actions bot removed the ok-to-test Label to trigger E2E tests label May 22, 2023
@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e/k8s-1.24

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e/k8s-1.24

Again failed with

  May 22 11:11:35.424: backend images not matching kubernetes resource count,image count 1 kubernetes resource count 0

@nixpanic nixpanic added the backport-to-release-v3.8 backport to release 3.8 branch label May 22, 2023
@nixpanic
Copy link
Member Author

Added the backport label, it is a harmless change, and with that we can test the label copier.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 22, 2023

/retest ci/centos/mini-e2e/k8s-1.24

Again failed with

  May 22 11:11:35.424: backend images not matching kubernetes resource count,image count 1 kubernetes resource count 0

@nixpanic are we hitting any bug as we hit it twice or is some issue with e2e itself?

@nixpanic
Copy link
Member Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented May 22, 2023

requeue

☑️ This pull request is already queued

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e/k8s-1.24

Again failed with

  May 22 11:11:35.424: backend images not matching kubernetes resource count,image count 1 kubernetes resource count 0

@nixpanic are we hitting any bug as we hit it twice or is some issue with e2e itself?

Oh, maybe the test did not get restarted? Or I checked the wrong logs? It is running now, so I assume it was my mistake.

@mergify mergify bot merged commit bc167cc into ceph:devel May 22, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-release-v3.8 backport to release 3.8 branch ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants