Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable debug logs in kubelet #4074

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Aug 24, 2023

enable debug logs in kubelet for better debugging.

enable debug logs in kubelet for
better debugging.

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 24, 2023

/retest ci/centos/mini-e2e/k8s-1.28

@mergify mergify bot added component/testing Additional test cases or CI work bug Something isn't working labels Aug 24, 2023
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is mostly done for #4073? Do you want to keep the level (4) in any case?

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 24, 2023

@nixpanic yes keeping it to `4 will help in debugging any CI issues.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 24, 2023

/retest ci/centos/mini-e2e/k8s-1.28

use resizer canary image to as it
might contain fix for pvc resize
with kubernetes 1.28

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 24, 2023

/retest ci/centos/mini-e2e/k8s-1.28

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e/k8s-1.27

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e/k8s-1.27

Wondering if the canary resize image works with Kubernetes 1.27 too.

@riya-singhal31
Copy link
Contributor

CI passed on 1.28

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 24, 2023

/test ci/centos/mini-e2e-helm/k8s-1.28

@nixpanic
Copy link
Member

Wondering if the canary resize image works with Kubernetes 1.27 too.

Seems to be fine 🥳

@riya-singhal31
Copy link
Contributor

/test ci/centos/mini-e2e-helm/k8s-1.28

This too passed!

nixpanic
nixpanic previously approved these changes Aug 24, 2023
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We at least need this in the devel branch for now. Hopefully a csi-resizer release is planned soon.

@nixpanic nixpanic requested a review from a team August 24, 2023 16:10
@nixpanic
Copy link
Member

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2023

rebase

✅ Nothing to do for rebase action

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Aug 24, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@nixpanic
Copy link
Member

Even with the label, it is running the full multi-arch-build instead of the single arch one. The arm64 repository from CentOS or Ceph has some inconsistency. Yesterday that was the case for amd64 too, but that seems to have been resolved.

@nixpanic nixpanic removed the ci/skip/multi-arch-build skip building on multiple architectures label Aug 25, 2023
@mergify mergify bot dismissed stale reviews from nixpanic and riya-singhal31 August 25, 2023 08:23

Pull request has been modified.

Some packages have dependencies on other repositories. On occasion these
repositories seem to be out-of-sync. In that case, install updates with
an older version, instead of erroring out.

Signed-off-by: Niels de Vos <[email protected]>
@nixpanic nixpanic added ci/skip/e2e skip running e2e CI jobs ok-to-test Label to trigger E2E tests labels Aug 25, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 25, 2023
@nixpanic
Copy link
Member

Added the ci/e2e/skip label as only the Dockerfile for the multi-arch-build has been modified. The e2e tests did pass without that change already, no need to run them again.

@nixpanic
Copy link
Member

/test ci/centos/k8s-e2e-external-storage/1.25

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e-helm/k8s-1.25

@nixpanic
Copy link
Member

/test i/centos/mini-e2e/k8s-1.25

@riya-singhal31
Copy link
Contributor

/test ci/centos/mini-e2e/k8s-1.25

@mergify mergify bot merged commit 16e5de5 into ceph:devel Aug 25, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci/skip/e2e skip running e2e CI jobs component/testing Additional test cases or CI work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants