rbd: update snap RbdImageName #4152
Conversation
|
@Mergifyio rebase |
This commit updates the snapshot RbdImageName with the clone RbdImageName before snapshot creation. This will fix the incorrect log statement. Signed-off-by: Praveen M <[email protected]>
✅ Branch has been successfully rebased |
Rakshith-R
force-pushed
the
fix/snap-name-before-create
branch
from
b146aa7
to
40209aa
Compare
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
| @@ -1340,10 +1340,10 @@ func (cs *ControllerServer) doSnapshotClone( | |||
| return nil, err | |||
| } | |||
|
|
|||
| // update rbd image name | |||
| rbdSnap.RbdImageName = cloneRbd.RbdImageName | |||
There was a problem hiding this comment.
Instead of logging rbdSnap, why not log cloneRbd?
Or, would it not be cleaner to set RbdImageName inside cloneRbd.createSnapshot()?
There was a problem hiding this comment.
Or, would it not be cleaner to set RbdImageName inside cloneRbd.createSnapshot()?
looks good to me, this PR got merged. Will raise another PR for the same.
Describe what this PR does
This PR updates the snapshot
RbdImageNamewith the cloneRbdImageNamebefore snapshot creation. This will fix theincorrect log statement.
Fixes: #4151