e2e: add multiple labels to node #4224
Conversation
Madhu-1
added
the
ci/skip/multi-arch-build
|
Can we do the same for |
i didnt noticed that earlier, Done same, PTAL |
| ) | ||
|
|
||
| func createNodeLabel(f *framework.Framework, labelKey, labelValue string) error { | ||
| func addLabelsToNodes(f *framework.Framework, labels map[string]string) error { |
There was a problem hiding this comment.
| func addLabelsToNodes(f *framework.Framework, labels map[string]string) error { | |
| func addNodeLabels(f *framework.Framework, labels map[string]string) error { |
There was a problem hiding this comment.
addLabelsToNodes seems more opt to me, same is used in Kuberentes util as well.
There was a problem hiding this comment.
thought using deleteNodeLabels and addNodeLabels would be a good idea.
There was a problem hiding this comment.
followed the format from the kubernetes package as an example, lets see what others think, based on the will change this if required.
|
@Mergifyio rebase |
update the e2e code to add multiple labels to the node at a time. fixes: ceph#4146 Signed-off-by: Madhu Rajanna <[email protected]>
update the e2e code to remove multiple labels to the node at a time. Signed-off-by: Madhu Rajanna <[email protected]>
✅ Branch has been successfully rebased |
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.27 |
not sure why it failed, e2e seems to report a panic logs |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
update the e2e code to add multiple labels to the node at a time.
fixes: #4146