util: include request-IDs in all gRPC calls for the Controller #4263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapshot procedures do not seem to contain the `Req-ID:` prefix in the logs anymore (or weren't they there at all?) for some reason. This adds them back. Signed-off-by: Niels de Vos <[email protected]>
Madhu-1
approved these changes
Nov 16, 2023
| @@ -97,7 +97,7 @@ func (s *nonBlockingGRPCServer) serve(endpoint string, srv Servers) { | |||
| klog.Fatalf("Failed to listen: %v", err) | |||
| } | |||
|
|
|||
| server := grpc.NewServer() | |||
| server := grpc.NewServer(NewMiddlewareServerOption(false)) | |||
There was a problem hiding this comment.
we can remove metrics argument from NewMiddlewareServerOption as it always set to false but it can be in separate PR.
There was a problem hiding this comment.
Removed in #4264
iPraveenParihar
approved these changes
Nov 16, 2023
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 0c13a70 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshot procedures do not seem to contain the
Req-ID:prefix in thelogs anymore (or weren't they there at all?) for some reason. This adds
them back.
Signed-off-by: Niels de Vos [email protected]