ci: make minikube.sh work on macOS M1 with the qemu2 driver #4368
Conversation
|
Please update commit message type from scripts to ci and reduce the length of body's line to max 80 chars by splitting into a new line, to make the checks passed. |
|
Have you tested this out? |
Some modifications have been made to handle the compatibility of bash scripts. For example, `sed -i` without a value only works for GNU sed, but not for macOS's sed. The RESOLV_CONF variable has been made configurable because it needs to be overridden as /etc/resolv.conf when using the qemu2 driver. In addition, minikube also supports adding extra disks for the qemu2 driver. Signed-off-by: zjx20 <[email protected]>
It works for my MBP M1 with macOS Monterey and minikube v1.32.0, but I haven't tested it on linux systems. |
zjx20
changed the title
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
Deploying in the CI still works 👍 I can not test this on a Mac, ideally someone else tries it out before this gets merged. |
|
Thank you @nixpanic. I hope someone will kindly try this branch on macOS M1 and give some feedback. Here are the instructions: export KUBE_VERSION=v1.28.3 # it's the latest version supported by minikube v1.32.0.
export MINIKUBE_ARCH=arm64
export VM_DRIVER=qemu2 # hyperkit is unavailable for arm64, so qemu2 is the only option for macOS M1
export CNI=auto
export RESOLV_CONF=/etc/resolv.conf
export CPUS=4 # "nproc" is unavailable on macOS, so explicitly set a number
export MEMORY=4096
export DISK_SIZE=20
./scripts/minikube.sh up
./scripts/minikube.sh deploy-rook |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
nixpanic
added
keepalive
Describe what this PR does
This PR makes scripts/minikube.sh work on macOS M1 with the qemu2 driver.
Some modifications have been made to handle the compatibility of bash scripts. For example,
sed -iwithout a value only works for GNU sed, but not for macOS's sed. TheRESOLV_CONFvariable has been made configurable because it needs to be overridden as /etc/resolv.conf when using the qemu2 driver. In addition, minikube also supports adding extra disks for the qemu2 driver.Related issues
No.
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)