Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update the mergify rule to exclude k8s 1.25 #4452

Merged
merged 2 commits into from
Feb 21, 2024
Merged

ci: update the mergify rule to exclude k8s 1.25 #4452

merged 2 commits into from
Feb 21, 2024

Conversation

yati1998
Copy link
Contributor

This commit excludes the k8s 1.25 check from the
mergify rules for ready-to-merge label

@yati1998 yati1998 changed the title ci: update the merfigy rule to exclude k8s 1.25 ci: update the mergify rule to exclude k8s 1.25 Feb 20, 2024
@mergify mergify bot added component/testing Additional test cases or CI work ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures Repo activity Process/activites on ceph-csi repo labels Feb 20, 2024
nixpanic
nixpanic reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK, but it assumes there will not be a Ceph-CSI 3.9.x update anymore. Are you certain that 3.9 is EOL (and that 3.10 is the oldest maintained version)?

@nixpanic nixpanic linked an issue Feb 20, 2024 that may be closed by this pull request
The ready-to-merge label expects CI runs for Kubernetes 1.25 on release-v3.10 #4449
Closed
@yati1998 yati1998 marked this pull request as ready for review February 20, 2024 13:33
nixpanic
nixpanic reviewed Feb 20, 2024
View reviewed changes
.mergify.yml
@@ -355,31 +355,6 @@ pull_request_rules:
- "status-success=ci/centos/upgrade-tests-cephfs"
- "status-success=ci/centos/upgrade-tests-rbd"
- "status-success=DCO"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ineeed, the devel + ready-to-merge rule will never be met, as GitHub requires 2 (real) reviews for PRs on the devel branch, Mergify is aware of that requirement automatically.

@nixpanic nixpanic requested a review from a team February 20, 2024 13:37
@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Feb 20, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Feb 20, 2024
@nixpanic
Copy link
Member

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 20, 2024

refresh

✅ Pull request refreshed

@yati1998
ci: update the merfigy rule to exclude k8s 1.25
87584bb 
This commit excludes the k8s 1.25 check from the
mergify rules for ready-to-merge label

Signed-off-by: Yati Padia <[email protected]>
@yati1998
ci: remove the merfigy rule for devel branch
f270978 
this commit removes the automatic merge rule
for devel branch as this is always overwritten
from the conditions above and is not required

Signed-off-by: Yati Padia <[email protected]>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Feb 21, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Feb 21, 2024
@mergify mergify bot merged commit 53b6280 into ceph:devel Feb 21, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work Repo activity Process/activites on ceph-csi repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The ready-to-merge label expects CI runs for Kubernetes 1.25 on release-v3.10
4 participants
@yati1998 @ceph-csi-bot @nixpanic @Madhu-1