Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of Style Options for Spaces Between Key and Description in Short Help View #571

Open
rrrodzilla opened this issue Jul 29, 2024 · 0 comments

Comments

@rrrodzilla
Copy link

rrrodzilla commented Jul 29, 2024

bubbles/help/help.go

Lines 132 to 134 in a9344b5

str := sep +
m.Styles.ShortKey.Inline(true).Render(kb.Help().Key) + " " +
m.Styles.ShortDesc.Inline(true).Render(kb.Help().Desc)

First, thank you for your work on this package.

In the ShortHelpView function, the space between the key and description does not have dedicated style options. This results in inconsistent styling, especially when a custom background color is applied to the terminal when using the alt window for a full screen TUI. As shown in the attached screenshot, the spaces remain unstyled with no ability to apply custom styles, which leads to visual discrepancies. All other parts of the help component have configurable styles, but these spaces do not, limiting the ability to achieve a consistent look and feel.

Screenshot:
image

To resolve this issue, I suggest the following approach:

  • Apply Separator Style: Use the existing SeparatorStyle to style the spaces between the key and description.
    Alternatively, you could:
  • Add a Whitespace Style: Introduce a WhitespaceStyle to style the spaces between the key and description, similar to the JoinHorizontal and JoinVertical methods.

If you settle on an approach, I'm happy to implement it and provide a PR. Thank you for considering this enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant