Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is 'normal' update mode consistent? #10474

Closed
2 of 3 tasks
stockiNail opened this issue Jul 11, 2022 · 0 comments · Fixed by #11017
Closed
2 of 3 tasks

Is 'normal' update mode consistent? #10474

stockiNail opened this issue Jul 11, 2022 · 0 comments · Fixed by #11017

Comments

@stockiNail
Copy link
Contributor

Documentation Is:

  • Missing or needed?
  • Confusing
  • Not sure?

Please Explain in Detail...

Having a look to some issues and some samples, I see that the users are suing the update mode equals to 'normal'.

export declare enum UpdateModeEnum {
resize = 'resize',
reset = 'reset',
none = 'none',
hide = 'hide',
show = 'show',
normal = 'normal',
active = 'active'
}

This is because in the types, update mode enum contains 'normal' as possible item. Nevertheless I don't see any mention in the documentation and in the code about his option. Furthermore I don't see 'default' as possible item for update mode in the types even is it's the default value in the code.

I think it's working because there isn't any explicit check in the code if the update mode is equals to 'default'.
Maybe I'm wrong but is there any reason why the types are defined with 'normal' instead of 'default'?

TS default reserved keyword?

Your Proposal for Changes

Maybe the type should be changed as following:

export declare enum UpdateModeEnum {
  resize = 'resize',
  reset = 'reset',
  none = 'none',
  hide = 'hide',
  show = 'show',
  default = 'default', // <- changed
  active = 'active'
}

Example

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant