Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation callbacks should actually be called #1711

Closed
etimberg opened this issue Nov 29, 2015 · 1 comment
Closed

Animation callbacks should actually be called #1711

etimberg opened this issue Nov 29, 2015 · 1 comment
Milestone

Comments

@etimberg
Copy link
Member

Configuration

The global configuration has two callback functions.

Chart.defaults.global.animation = {
    onProgress: function() {},
    onComplete: function() {},
}

Core Controller

The Core controller attaches different functions from the config to the animation object here

The controller will call onAnimationComplete if the animation duration is 0 milliseconds.

Animation Controller

The animation controller does not fire either onAnimationProgress or onAnimationComplete

Examples

As fixing this, a sample file demonstrating the onAnimationProgress / onAnimationComplete functions should be created.

@etimberg etimberg added this to the v2.0 milestone Nov 29, 2015
@etimberg
Copy link
Member Author

Closing as #1775 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant