Chart does not draw if animation.duration = 0

[mathiask88]

If I create a static chart with an inital dataset and animations turned off the chart is not drawn. If the window is resized the chart is displayed sometimes. 2.0-dev

[mathiask88]

I found the bug. Sometimes there was an onresize event triggered although the size did not change. And the resize function set a new width to the canvas which is equivalent to clearRect.

I fixed this by returning the resize function if the size did not really change.

diff --git src/core/core.controller.js src/core/core.controller.js
index e4da7af..c0487fb 100644
--- src/core/core.controller.js
+++ src/core/core.controller.js
@@ -90,12 +90,15 @@

            var sizeChanged = this.chart.width !== newWidth || this.chart.height !== newHeight;

+           if (!sizeChanged)
+               return this;
+
            canvas.width = this.chart.width = newWidth;
            canvas.height = this.chart.height = newHeight;

            helpers.retinaScale(this.chart);

-           if (!silent && sizeChanged) {
+           if (!silent) {
                this.stop();
                this.update(this.options.responsiveAnimationDuration);
            }

[etimberg]

Fixed in #1911

[mathiask88]

Maybe also fixes #1904?

[etimberg]

It might. I'll leave a comment on it