Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary calls to hw.news.render(). #71

Open
Leftium opened this issue May 7, 2022 · 0 comments
Open

Unnecessary calls to hw.news.render(). #71

Leftium opened this issue May 7, 2022 · 0 comments

Comments

@Leftium
Copy link

Leftium commented May 7, 2022

hw.news.render() is called for routes that don't display the news list, like https://hackerweb.app/#/about, or a specific news item.

This may result in unnecessary calls to the HN API. It also caused other problems in my fork.

I fixed it in my fork by moving the call like this: Leftium@4845c1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Leftium