Should DanteDevice.add_subscription use channel friendly names?

[jamesremuscat]

DanteDevice.add_subscription passes tx_channel.name to its command_add_subscription method. Dante naming weirdness means that channel "names" are always '01', '02' etc.

This works, and audio is routed appropriately, but it confuses Dante Controller into not knowing where that subscription is coming from: it gives green checkmarks against the tx device, but doesn't know which column to put them in.

By way of example: here ATEM-Input is subscribed to channels 1 and 2 from SQ6-Broadcast. The subscriptions were made with netaudio.

These channels have friendly names of Broadcast L and Broadcast R respectively. You can see that Dante Controller thinks the subscriptions are actually to channels called 01 and 02 - which, surprisingly, works and audio gets passed appropriately.

Should add_subscription be using these friendly names if present? (Come to think of it, should these friendly names be used in place of names everywhere they're used?)