Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h264: we should check first_mb_in_slice when decoding #38

Open
dwlsalmeida opened this issue Jul 11, 2023 · 2 comments
Open

h264: we should check first_mb_in_slice when decoding #38

dwlsalmeida opened this issue Jul 11, 2023 · 2 comments

Comments

@dwlsalmeida
Copy link
Collaborator

From the specification:

first_mb_in_slice specifies the address of the first macroblock in the slice

If first_mb_in_slice == 0 this means that we have identified that the slice belongs to a new picture.

This should be one of the conditions checked here

This is not a problem when testing with fluster because we check for this when using H264FrameIterator, but clients are free to submit data as they see fit.

@dwlsalmeida
Copy link
Collaborator Author

It would be great if we could assert! or debug_assert! these two conditions:

–If separate_colour_plane_flag is equal to 0, the value of first_mb_in_slice shall not be less than the value of
first_mb_in_slice for any other slice of the current picture that precedes the current slice in decoding order.

–Otherwise (separate_colour_plane_flag is equal to 1), the value of first_mb_in_slice shall not be less than the value
of first_mb_in_slice for any other slice of the current picture that precedes the current slice in decoding order and has
the same value of colour_plane_id.

@Gnurou Gnurou closed this as completed in c199812 Jul 20, 2023
@Gnurou
Copy link
Collaborator

Gnurou commented Jul 22, 2023

Reopening to address the comments right above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants