Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H.264/5: confirm visible_rectangle's semantics #81

Open
Gnurou opened this issue Jun 30, 2024 · 0 comments
Open

H.264/5: confirm visible_rectangle's semantics #81

Gnurou opened this issue Jun 30, 2024 · 0 comments

Comments

@Gnurou
Copy link
Collaborator

Gnurou commented Jun 30, 2024

While this methods returns a rectangle with min and max members, its max member seems to only take the width and height into account.

This ambiguity propagates to the visible_rect method of the VAAPI backend, which should probably use the same Rect type as these methods?

The computation of the visible width and height is performed in the visible_rectangle and in the parse_sps methods, using apparently slightly different methods. Need to verify with the spec which one is correct - also the pre-computed values in parse_sps are never used afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant