Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't work in Suckless' tabbed #12

Open
GasparVardanyan opened this issue May 15, 2021 · 3 comments
Open

doesn't work in Suckless' tabbed #12

GasparVardanyan opened this issue May 15, 2021 · 3 comments

Comments

@GasparVardanyan
Copy link

When I use ucollage in a plain st window, it works fine, but when I use ucollage in a st instance embedded in a tabbed window, ucollage doesn't draw images.

@ckardaris
Copy link
Owner

I can reproduce the problem with xterm using tabbed.

I am confident that the problem is with how ueberzug draws images. What happens is that they are drawn on the parent window.

If you explicitly run tabbed -c xterm -into (or the st variant) in a terminal window, xterm in tabbed mode opens. If you run ucollage inside that new window, you will notice that the images are drawn on the parent window and the text is drawn correctly on the new window. So ueberzug draws the images on the window of the tabbed command and not on its child.

15-05-2021_15 26-56
15-05-2021_15 27-03

I am not really sure what information is passed when a program is executed with tabbed, so I don't think there is an immediate fix for this.

In any case, I don't think the solution can come by changing something in the ucollage code.

@euglevi
Copy link

euglevi commented May 20, 2021

First of all, thank you for the app! I like it a lot.

This is just to confirm that this happens also when you open a terminal inside Vim/Neovim. Images are shown on the left-hand side even if the terminal is in a vertical split on the right. However, and this may be interesting in relation to this issue, this does not happen when the terminal is moved to the left. So, it seems that ucollage renders images on the left in the terminal no matter what.

@ckardaris
Copy link
Owner

ckardaris commented May 20, 2021

I think it works as expected based on the model I have in mind. ueberzug will draw the images on the X window. It can't differentiate between splits. ucollage will read correctly the terminal size but the drawings will be relative to the whole window and consequently it's upper left part.

The split part could maybe be made to work if we had a way to determine the the current split provided. It's really interesting. Let me think about that.

In any case modifying ueberzug would make more sense. But hacks are fun, so at some point I may give a try to the split terminal issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants