Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion opens in the wrong place when collapsed posts are present. #2

Open
deteh opened this issue Jun 6, 2024 · 2 comments
Open

Comments

@deteh
Copy link

deteh commented Jun 6, 2024

Example:

Discussion with 248 posts.
Somewhere early in the discussion 15 posts in a few groups are collapsed.
User that had seen the entire discussion clicks on the topic from the list (url contains /248).

Expectation:
User lands on post no. 248

Reality:
User somehow lands on post 226 (?)

Un-collapsing posts fixes the issue with discussion and user lands correctly on post 248.

Flarum 1.8.5
PHP 8.2.5
clarkwinkelmann/flarum-ext-collapsible-posts v1.0.1

No visible errors in console.

@clarkwinkelmann
Copy link
Owner

Thanks for the report! I'm not able to take a look right now, but will try to do in the coming weeks.

@clarkwinkelmann
Copy link
Owner

I am unable to replicate the issue.

I created a test discussion with 150 replies, collapsed multiple groups of posts in various places in the discussion. It always opens exactly at the bottom of the stream when clicked from the homepage.

Do you have images in some of the posts?

Do you happen to still have a page where this behavior is present? I might be able to take a look, even just as a guest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants