-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GaugeSolution.write format? #542
Comments
I would favor them being identical but also long. We should probably explicitly format the Python and make the Fortran longer then? |
Ideally we would make it easy to control how long. Some applications require many gauges over very many time steps and the gauge files can get huge. Ideally we would also support binary gauge output in the Fortran code. Maybe these are enhancements for the future. For now I'm fine with leaving the |
My preferred change would be to make both of them print all the digits, as @mandli suggests. |
I notice that in
src/pyclaw/gauges.py
,GaugeSolution.write
uses different formatting than the Fortran code, e.g. producinginstead of the Fortran output:
The Python version would potentially print more significant figures although maybe not all since
%s
formatting is used, e.g.produces '3.14159265359'.
Should we use the same format in both cases? Are the 7 digits we print from Fortran always enough?
The text was updated successfully, but these errors were encountered: