-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG format #167
Comments
Agreed @Ragazzo but I seriously need help here... I am so busy and I am currently working to update to YiiBooster 1.0.6, wish to include a couple of other widgets and I have to update at the same time Yiibooster site. For docs, Pinocchio is fine... I think that after version 1.0.6 I will hold my self a bit to add more widgets (I have about 8 more to add) and will work on the API documentation. The docs should be written within the comments of the files, then with Pinocchio we can build a seriously cool API doc. |
8 more widgets, cool) i will try to update new changelog format and rows in it. (will search for PR numbers to make chagelog like in yii repo). |
How about to use the step 7 from https://github.com/yiisoft/yii/wiki/Git-workflow-for-Yii-contributors ? 7. Update the CHANGELOGEdit the CHANGELOG file to include your change, you should insert this at the top of the file under the "Work in progress" heading, the line in the change log should look like one of the following: Bug #999: a description of the bug fix (Your Name) Enh #999: a description of the enhancement (Your Name)
For very small fixes, e.g. typos and documentation changes, there is no need to update the CHANGELOG. |
Hi think makes a lot of sense and is actually the right way to go... |
Just making sure if I'm reading this correctly. If we send a PR, we should update CHANGELOG with that PR? |
yes, like in Yii repo wiki is written. |
Well, I've added this step to the wiki as an additional step to take when contributing. In dc57204 I've edited the I suppose this issue can be closed now. |
I am bit confused. and I would suggest to merge the contributor's code to the wip branch before the pull request so the work load would be less. |
@rumal Ooops... true, I mixed up two different things there. Main point of checking out the Clevertech's repo is that you'll create a new feature branch from the most current I changed the proposed workflow to better explain what you should do to make contribution the easiest way. |
@tonydspaniard may be use format like in yii repo, because its good and very helpful to find info about changes and PR that was made?
The text was updated successfully, but these errors were encountered: