Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Install ASP.NET Core Runtime by --framework parameter #152

Closed
danilobreda opened this issue Mar 23, 2023 · 10 comments
Closed

Install ASP.NET Core Runtime by --framework parameter #152

danilobreda opened this issue Mar 23, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@danilobreda
Copy link

danilobreda commented Mar 23, 2023

Its possible to install the ASP.NET Core Runtime by --framework parameter ?
I think the only framework that i can download is the Desktop version.

https://dotnet.microsoft.com/en-us/download/dotnet/7.0

@caesay caesay added the enhancement New feature or request label Apr 26, 2023
@danilobreda
Copy link
Author

I discovered that static DotnetInfo Parse(string input) can translate the "net7-x86-asp" for {[net7-x86-asp] .NET 7 AspNetCore (x86)}, so its maybe possible to download it dinamically today.
image

@danilobreda
Copy link
Author

Its not, i get this error:

throw new Exception($"Runtime '{f}' is unsupported. Specify a dotnet runtime (eg. 'net6.0') or a static runtime such as: {String.Join(", ", Runtimes.All.Select(r => r.Id))}");

@caesay
Copy link
Member

caesay commented Apr 26, 2023

I'll work on this for the next release of v3

@caesay
Copy link
Member

caesay commented Apr 26, 2023

I have just tested this with the latest version of the code in the develop branch and this appears to be working as expected. Can you clarify where you tested/got that error? The current develop code with the new -asp postfixes have not yet been released - so if you are testing via nuget that is why you saw the error.

@danilobreda
Copy link
Author

danilobreda commented Apr 27, 2023

@caesay i tested on the build pipeline that i think is the nuget version. Good news that its working on develop! When it release to nuget i will use it. For now im publishing my app as a selfcontained, that dont need to have the runtime installed.

@luislhg
Copy link

luislhg commented Jul 4, 2023

@caesay in develop, would this work? --framework net6, net6-asp? Meaning, install net6 desktop and net6 asp core runtimes?
Also, any way to make this work in master version?

@caesay
Copy link
Member

caesay commented Jul 7, 2023

It has been developed but not released to nuget yet. Since it's on develop it will likely only be a v3 feature.

@luislhg
Copy link

luislhg commented Sep 1, 2023

Actually this has a bug even in develop, the URL is fixed to WindowsDesktop.
In the logs you can see it wants to download asp, but the actual url it downloads is not.

2023-08-31 16:36:57.7444 [INFO] - Runtimes: Downloading net6.0.21-x64-asp from https://dotnetcli.azureedge.net/dotnet/WindowsDesktop/6.0.21/windowsdesktop-runtime-6.0.21-win-x64.exe to C:\Users\Admin\AppData\Local\SquirrelClowdTemp\tempa\net6.0.21-x64-asp.exe

I fixed and tested this here #176

@luislhg
Copy link

luislhg commented Sep 1, 2023

I added support for aspnetcore runtime and .NET 7 in this PR #177
Hopefully it fixes and closes this issue

@caesay
Copy link
Member

caesay commented Nov 4, 2023

Closed by 220588d

@caesay caesay closed this as completed Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants