Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Can't detect AssemblyMetadata attribute in a SingleFile app #2

Closed
caesay opened this issue Aug 29, 2021 · 1 comment
Closed

Can't detect AssemblyMetadata attribute in a SingleFile app #2

caesay opened this issue Aug 29, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@caesay
Copy link
Member

caesay commented Aug 29, 2021

Mono.Cecil can't load an exe produced by PublishSingleFile. Do we try to read the entry assembly by looking for the bundle offset and parse the attribute? Probably not a great idea as these bundles might change significantly in future versions of dotnet.

It's also not possible to add the native SquirrelAwareApp entry to the version table (with rcedit or other) because this breaks the bundle. (see #1)

Perhaps we need a way to detect a Squirrel app that is a bit more universal. Reading exe manifest? Looking for a sidecar file (eg. myapp.exe.squirrel)?

@caesay caesay added the enhancement New feature or request label Aug 30, 2021
@caesay caesay closed this as completed in a918f2c Sep 8, 2021
@caesay
Copy link
Member Author

caesay commented Sep 8, 2021

An entry in the assembly manifest can now be used to indicate a squirrel aware binary. This manifest can be read from single file apps.

For example:

<?xml version="1.0" encoding="utf-8"?>
<assembly manifestVersion="1.0" xmlns="urn:schemas-microsoft-com:asm.v1">
  <SquirrelAwareVersion>1</SquirrelAwareVersion>
</assembly>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant