Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Replace WebClient with HttpClient in FileDownloader #20

Closed
simader opened this issue Jan 5, 2022 · 3 comments
Closed

Replace WebClient with HttpClient in FileDownloader #20

simader opened this issue Jan 5, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@simader
Copy link

simader commented Jan 5, 2022

Hi Casey,

warning SYSLIB0014: 'WebClient.WebClient()' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.'

Do you have any plans to remove the WebClient und use HttpClient in FileDownloader.cs instead?

Best,
Andreas
@caesay caesay added the enhancement New feature or request label Jan 5, 2022
@caesay
Copy link
Member

caesay commented Jan 5, 2022

I will leave FileDownloader as-is, accepting a WebClient (for backwards compatibility) but it is on my list to create a HttpClientFileDownloader class which will be used by default. Also, the Utility.CreateWebClient() function should return a HttpClientFileDownloader instead of a WebClient.

@caesay caesay added the good first issue Good for newcomers label Jan 5, 2022
@caesay
Copy link
Member

caesay commented Jan 5, 2022

Would also accept a PR if you are willing to look at it

@caesay caesay changed the title Improvement: Replace WebClient with HttpClient in FileDownloader Replace WebClient with HttpClient in FileDownloader Jan 5, 2022
@caesay caesay closed this as completed in ecea6e1 Jan 6, 2022
@caesay
Copy link
Member

caesay commented Jan 17, 2022

This is now released in 2.7.79.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caesay @simader