Skip to content
This repository has been archived by the owner on Oct 4, 2018. It is now read-only.

Transition entire api to async #47

Open
cobbdb opened this issue Aug 5, 2016 · 1 comment
Open

Transition entire api to async #47

cobbdb opened this issue Aug 5, 2016 · 1 comment

Comments

@cobbdb
Copy link
Owner

cobbdb commented Aug 5, 2016

defineSlot() and load() will need callbacks. One option is to expose a promise:

harmony.defineSlot({..}).then(function (slot) {
    // do things with the slot.
});

... or with normal callbacks ...

harmony.defineSlot({..}, function (slot) {
    // do things with the slot.
});

The goal is to wrap the api inside of googletag.cmd for stability.

@cobbdb cobbdb modified the milestone: Version 7 Aug 24, 2016
@cobbdb cobbdb removed this from the Version 7 milestone Nov 9, 2016
@cobbdb cobbdb added this to the Version 7.next milestone Nov 9, 2016
@cobbdb cobbdb removed this from the Version 7.next milestone Nov 9, 2016
@cobbdb cobbdb added this to the Version 8 milestone Feb 16, 2017
@cobbdb
Copy link
Owner Author

cobbdb commented Oct 17, 2017

Would need to shim promise.. probably save that for a someday wishlist
http://caniuse.com/#feat=promises

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant