Skip to content
This repository has been archived by the owner on Oct 4, 2018. It is now read-only.

Optionally install gpt.js by default #74

Open
cobbdb opened this issue Dec 12, 2017 · 1 comment
Open

Optionally install gpt.js by default #74

cobbdb opened this issue Dec 12, 2017 · 1 comment

Comments

@cobbdb
Copy link
Owner

cobbdb commented Dec 12, 2017

Append gpt.js if not already included. Nice quality of life feature to simplify setup.

For example, where calling show.all() would include quick and fast check if gpt has already been installed and setup. If not, then wrap the action in googletag.cmd and append the gpt.js script. Will have to remember if we've already dropped in the script to avoid duplicates.

@cobbdb cobbdb added this to the Version 7.next milestone Dec 12, 2017
@cobbdb
Copy link
Owner Author

cobbdb commented Dec 12, 2017

Should be optional - allow people to disable with some kind of setting like

harmony.disable.gptInstall()

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant