Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gogoprotobuf replacement #138

Open
jdmeyer3 opened this issue Apr 17, 2024 · 2 comments
Open

Gogoprotobuf replacement #138

jdmeyer3 opened this issue Apr 17, 2024 · 2 comments

Comments

@jdmeyer3
Copy link

jdmeyer3 commented Apr 17, 2024

Since gogo/protobuf has been deprecated since January of 2021, are there any thoughts on replacing it with any other protocol buffer library or simply using the vanilla golang protobuf library?

This has been brought up in earlier discussions (#80)

@rsc
Copy link

rsc commented Jul 9, 2024

I am running into this too, with errors as a dependency of pebble. Bringing in gogo/protobuf brings in references to very old other packages that I can't eliminate. The normal way to eliminate them would be to get gogo/protobuf to update their dependencies, but gogo/protobuf is deprecated so they're not doing updates.

It seems like for this usage, the ordinary Go protobuf library should be fine.

@pqn
Copy link

pqn commented Jul 14, 2024

In case it's useful, I've just started a fork to attempt to remove it. I wasn't really concerned about migrating the gRPC middleware for my use case, so I just deleted it: v1.11.3...Exafunction:errors:exa-v1.11.3

The same set of tests that passes in the latest release tag also passes, but I've yet to test with our real services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants