Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout issues with multiline text and cell reuse(?) #2

Open
ole opened this issue Jul 28, 2019 · 1 comment
Open

Layout issues with multiline text and cell reuse(?) #2

ole opened this issue Jul 28, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@ole
Copy link
Collaborator

ole commented Jul 28, 2019

Some table cells with text (TextCell) are not always laid out correctly. This seems to happen especially when a cell is reused and its new content is longer (more lines) than it was before. But I'm also seeing it when I rotate an iPhone from portrait to landscape, which shouldn't trigger cell reuse as far as I know.

Steps to reproduce:

  1. Select a number of photos in Photos.app (10 to 20) and share them to Share Inspector.

    Ideally, there should be a few HEIC and Live Photos in the mix because those will cause Photos to provide multiple type identifiers, making the registeredTypeIdentifiers field multiline.

  2. Scroll through the table and observe the cell layout. Is everything correct?

  3. Rotate the device from portrait to landscape? Are cell layouts correct after rotation?

I added a hack that a cell gets reloaded (hopefully triggering relayout) when you tap it, but that's not a good solution.

IMG_3160

@ole ole added the bug Something isn't working label Jul 28, 2019
@ole
Copy link
Collaborator Author

ole commented Aug 2, 2019

It seems to work correctly when I disable dynamic switching between vertical and horizontal stacking (depending on the text length in the two labels). So that seems to be the source of the issue, not the self-sizing table cells per se.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant